<html>
<head><meta charset="utf-8"><title>rollup=maybe · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html">rollup=maybe</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="204614295"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204614295" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204614295">(Jul 21 2020 at 23:19)</a>:</h4>
<p>It is not super clear what <code>rollup=maybe</code> means in relation to rollup not being specified at all.</p>



<a name="204614323"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204614323" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204614323">(Jul 21 2020 at 23:19)</a>:</h4>
<p>is it more rollup than no rollup or less…?</p>



<a name="204615470"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204615470" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204615470">(Jul 21 2020 at 23:37)</a>:</h4>
<p>More</p>



<a name="204615471"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204615471" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204615471">(Jul 21 2020 at 23:37)</a>:</h4>
<p>I think</p>



<a name="204615487"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204615487" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204615487">(Jul 21 2020 at 23:37)</a>:</h4>
<p>AFAIK there should only be 3 states though, iffy never and (neutral)</p>



<a name="204615514"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204615514" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204615514">(Jul 21 2020 at 23:38)</a>:</h4>
<p>I'm not actually sure which maybe maps to</p>



<a name="204615563"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204615563" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204615563">(Jul 21 2020 at 23:38)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust-forge/pull/402">https://github.com/rust-lang/rust-forge/pull/402</a> will improve our procedure</p>



<a name="204615598"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204615598" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Yuki Okushi <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204615598">(Jul 21 2020 at 23:39)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/242791-t-infra/topic/rollup.3Dmaybe/near/204615487">said</a>:</p>
<blockquote>
<p>AFAIK there should only be 3 states though, iffy never and (neutral)</p>
</blockquote>
<p>and <code>always</code> :)</p>



<a name="204617046"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204617046" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204617046">(Jul 21 2020 at 23:59)</a>:</h4>
<p>ah right</p>



<a name="204655410"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204655410" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204655410">(Jul 22 2020 at 11:51)</a>:</h4>
<p>rollup=maybe is the default case, where the reviewer isn't sure whether it needs to be reviewed or not and is left to the person doing the rollup to decide whether to include it in a rollup or not</p>



<a name="204670432"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204670432" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204670432">(Jul 22 2020 at 14:10)</a>:</h4>
<p>There is a PR at <a href="https://github.com/rust-lang/rust-forge/pull/402">https://github.com/rust-lang/rust-forge/pull/402</a> which tries to clarify things.</p>
<p>always &gt; maybe &gt; iffy &gt; never</p>



<a name="204670527"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204670527" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204670527">(Jul 22 2020 at 14:11)</a>:</h4>
<p>(would appreciate feedback to enhance/clarify that PR, since I haven't received much)</p>



<a name="204670641"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204670641" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204670641">(Jul 22 2020 at 14:12)</a>:</h4>
<p>Should extend it <code>maybe</code> is 50/50. <code>maaaaybe</code> is 7% confidence.</p>



<a name="204670725"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204670725" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> kennytm <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204670725">(Jul 22 2020 at 14:13)</a>:</h4>
<p>add one <code>a</code> to reduce by 5%</p>



<a name="204670847"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204670847" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204670847">(Jul 22 2020 at 14:14)</a>:</h4>
<p>so, should <code>maaaaaaaaaaaaybe</code> directly close the PR?</p>



<a name="204670997"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204670997" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> kennytm <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204670997">(Jul 22 2020 at 14:15)</a>:</h4>
<p>it should mean something like p=1000 <span aria-label="stuck out tongue" class="emoji emoji-1f61d" role="img" title="stuck out tongue">:stuck_out_tongue:</span></p>



<a name="204671054"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204671054" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204671054">(Jul 22 2020 at 14:15)</a>:</h4>
<p>would you <code>p=1000</code> a PR where you have -5% confidence it will land? <span aria-label="upside down" class="emoji emoji-1f643" role="img" title="upside down">:upside_down:</span></p>



<a name="204671180"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204671180" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> kennytm <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204671180">(Jul 22 2020 at 14:16)</a>:</h4>
<p>the -5% confidence is about rollup though <span aria-label="slight smile" class="emoji emoji-1f642" role="img" title="slight smile">:slight_smile:</span></p>



<a name="204677912"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204677912" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mati865 <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204677912">(Jul 22 2020 at 15:04)</a>:</h4>
<p>Unless it's unsigned type, then negative confidence would underflow and become probably highest confidence level so far.</p>



<a name="204705549"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/rollup%3Dmaybe/near/204705549" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/rollup.3Dmaybe.html#204705549">(Jul 22 2020 at 18:39)</a>:</h4>
<p><code>rollup=now</code></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>